search

hyperledger / fabric

Hyperledger Fabric is an enterprise-grade permissioned distributed ledger framework for developing solutions and applications. Its modular and versatile design satisfies a broad range of industry use cases. It offers a unique approach to consensus that enables performance at scale while preserving privacy.
https://wiki.hyperledger.org/display/fabric
Apache License 2.0
15.77k stars 8.86k forks source link

bump github.com/alecthomas/kingpin/v2 to v2.4.0 #5023

Closed pfi79 closed 1 month ago

pfi79 commented 1 month ago

@denyeart The author of this library is weakly supportive, which is what he wrote about. He himself switched to the kong library.

Perhaps we should get rid of it in fabric. Should I switch to cobra and viper, as is done in peer, or to the same kong?

denyeart commented 1 month ago

@denyeart The author of this library is weakly supportive, which is what he wrote about. He himself switched to the kong library.

Perhaps we should get rid of it in fabric. Should I switch to cobra and viper, as is done in peer, or to the same kong?

From my memory kingpin was simpler than cobra, so I'd be ok leaving it on the older kingpin (no update) to keep things simple. If you really want to invest your time in an update to kong or cobra then I'd be fine with it, up to you.

pfi79 commented 1 month ago

@denyeart The author of this library is weakly supportive, which is what he wrote about. He himself switched to the kong library. Perhaps we should get rid of it in fabric. Should I switch to cobra and viper, as is done in peer, or to the same kong?

From my memory kingpin was simpler than cobra, so I'd be ok leaving it on the older kingpin (no update) to keep things simple. If you really want to invest your time in an update to kong or cobra then I'd be fine with it, up to you.

Okay, maybe sometime in the future.

pfi79 commented 1 month ago

I'd be ok leaving it on the older kingpin (no update) to keep things simple

then I'm closing the pr?

denyeart commented 1 month ago

Yes, let's close the PR. The command utilities have been very stable, and the no-help thing is confusing, let's keep current dependency.