hyperledger / firefly-cli

FireFly Command Line Interface (CLI)
Apache License 2.0
56 stars 50 forks source link

"init" option to copy in a custom docker-compose.override.yml file #285

Open Philip-21 opened 5 months ago

Philip-21 commented 5 months ago

This is pr fixes for #184

Philip-21 commented 5 months ago

@nguyer , @awrichar i have been able to tackle this issue so far with implementations i have made please i would like reviews, and i am wondering why the e2e tests are failing . I tested everything out and they worked fine, below are the snapShot results

Philip-21 commented 5 months ago

proof-oo1

i tested the command ff init --override "docker-compose.yml" to copy the contents from the docker-compose file to the docker-override file

Philip-21 commented 5 months ago

hyperledger-1

The docker-compose.yml file's content gets copied to the docker-compose-override.yml file in the stack i created ?

Philip-21 commented 5 months ago

proof-oo2

the docker-compose.yml file

nguyer commented 5 months ago

The E2E tests are failing with this error:

ff -v --ansi never init ethereum --prometheus-enabled --database sqlite3 firefly_e2e 2 --token-providers erc1155 --manifest ../../manifest.json --sandbox-enabled=false --multiparty=true
initializing new FireFly stack...
Error: failed to copy file data to docker-compose.override.yml: open : no such file or directory
Philip-21 commented 5 months ago

@nguyer I have corrected it, all checks pass successfully, and the docker -override works

Philip-21 commented 2 months ago

Hi @nguyer is this pr still open or i should close it ?