search

hyperledger / firefly-cli

FireFly Command Line Interface (CLI)
Apache License 2.0
58 stars 55 forks source link

cmd tests implementations #286

Closed Philip-21 closed 9 months ago

Philip-21 commented 10 months ago

This pr fixes for #7

Philip-21 commented 9 months ago

@nguyer I have been able to create vast amount of unit tests here . This can be merged

Philip-21 commented 9 months ago

This is great. Thank you for adding so many tests! I think we should do two things before this could be merged.

  1. Can you merge the fix-tests branch into this one? Fix tests #288 I fixed a number of issues with the existing tests in this branch, including making them run as a part of the CI workflow (using make). I want to make sure we have all tests passing before we merge.
  2. Can you make sure that none of the tests leave a modified git tree when they are done? Right now it looks like some of the tests write a file that is not cleaned up at the end of the test. You can refer to my branch/PR for how to use t.TempDir() in tests to solve this issue

I will do all these

Philip-21 commented 9 months ago

Wonderful! Thank you so much for contributing this!

My pleasure