search

hyperledger / firefly-cli

FireFly Command Line Interface (CLI)
Apache License 2.0
58 stars 55 forks source link

Enable an instance of tezossigner to deploy a contract using FF core API #298

Closed alex-semenyuk closed 7 months ago

alex-semenyuk commented 8 months ago

Related PRs to firefly and firefly-tezosconnect

nguyer commented 7 months ago

Hey @alex-semenyuk I'm happy to include this, but I'm unclear on how someone would use this command with these changes. Do you also need to add a ff deploy tezos sub command?

alex-semenyuk commented 7 months ago

Hey @alex-semenyuk I'm happy to include this, but I'm unclear on how someone would use this command with these changes. Do you also need to add a ff deploy tezos sub command?

Hey @nguyer As I mentioned at description it's required for new implemented deploy API. We need to add 'origination' as allowed transaction value for the given address config Originating means the same as Deploying contract

nguyer commented 7 months ago

Okay so this is just making the change to enable an instance of tezossigner to deploy a contract that is created by the FireFly CLI? And we could have separate PR later to allow the user to actually deploy a contract with the FireFly CLI?

denisandreenko commented 7 months ago

@nguyer you're right. It unblocks tezossigner for a contract deployment, so we can use FF core API to make a deployment request. CLI support will be added next.

alex-semenyuk commented 7 months ago

@nguyer @denisandreenko Thanks! Changed the name of this PR to avoid confusion. Also going to add support deploying via CLI in the next iterations/PRs.