hyperledger / firefly-tokens-erc20-erc721

ERC20 and ERC721 token integration
https://github.com/hyperledger/firefly-tokens-erc20-erc721
Apache License 2.0
20 stars 22 forks source link

Change ERC721 samples to use auto-indexing mint by default #109

Closed awrichar closed 1 year ago

awrichar commented 1 year ago

With this change, the default "out of the box" sample for ERC721 will not require (or allow) you to pass a token index when minting. It will choose an increasing token index starting from 0.

Via ERC165 support, the connector can now check for 3 different versions of the ERC721WithData interface:

For the "no data" variant, we have no ERC165 support, so I have destructively replaced the ERC721NoData sample with a new one that uses auto-indexing. Note that it was just replaced in #104 and released as v1.2.0 - I don't really see any need to preserve all the versions of this sample, so I'm just preserving this new one and the original (not the interim one introduced in v1.2.0). This new PR will probably need to become release v1.2.1, and we'll just want to note that the sample in v1.2.0 is not supported.