search

hyperledger / firefly-tokens-erc20-erc721

ERC20 and ERC721 token integration
https://github.com/hyperledger/firefly-tokens-erc20-erc721
Apache License 2.0
20 stars 22 forks source link

Tokens connectors send more than one ack per batch to EVMConnect/EthConnect #87

Closed peterbroadhurst closed 2 years ago

peterbroadhurst commented 2 years ago

Found during test with EVMConnect, after implementation of #86. However, it might have been the case that additional acks were sent previously too.

grep 'Received WebSocket ack for batch 4850' log_evmconnect_0.window.log 
[2022-09-10T20:09:04.878Z] DEBUG evmconnect: Received WebSocket ack for batch 4850 on topic 'tokens_0_0' wsc=3817fb31-bab7-4619-85d4-87629c7b08cd
[2022-09-10T20:09:04.918Z] DEBUG evmconnect: Received WebSocket ack for batch 4850 on topic 'tokens_0_0' wsc=3817fb31-bab7-4619-85d4-87629c7b08cd
[2022-09-10T20:09:04.944Z] DEBUG evmconnect: Received WebSocket ack for batch 4850 on topic 'tokens_0_0' wsc=3817fb31-bab7-4619-85d4-87629c7b08cd
[2022-09-10T20:09:04.944Z] DEBUG evmconnect: Received WebSocket ack for batch 4850 on topic 'tokens_0_0'. Too many spurious acks - closing connection wsc=3817fb31-bab7-4619-85d4-87629c7b08cd

See this thread for details: https://discord.com/channels/905194001349627914/1018534626479837294

peterbroadhurst commented 2 years ago

Resolved now and validated 👍