hyperledger / firefly

Hyperledger FireFly is the first open source Supernode: a complete stack for enterprises to build and scale secure Web3 applications. The FireFly API for digital assets, data flows, and blockchain transactions makes it radically faster to build production-ready apps on popular chains and protocols.
https://hyperledger.github.io/firefly
Apache License 2.0
508 stars 209 forks source link

Status call returns error when node is not registered to a multiparty namespace #1453

Closed chrisbygrave closed 6 months ago

chrisbygrave commented 10 months ago

Before this change I could register my org using the org/self API, and then subsequently register my node using self/node. In the time between the two registrations completing successfully, FireFly ran normally and I could call /status to check on the completion of the registration calls.

After the above change, I am getting an error from the /status call:

{"error":"FF10225: Unable to resolve the local node. Please ensure node.name is configured"}

It looks like the change has resulted in the missing node name being treated as an error rather than an acceptable state. This makes client logic more difficult to manage - if registration requires two separate asynchronous calls, then being in a state where one has completed without the other needs to be tolerated.

peterbroadhurst commented 10 months ago

Thanks @chrisbygrave - I think it's worth considering https://github.com/hyperledger/firefly/issues/1450 alongside this when we get an owner, as they're likely to be architecturally in the same place

chrisbygrave commented 6 months ago

Now fixed by https://github.com/kaleido-io/firefly/pull/102