search

hyperledger / firefly

Hyperledger FireFly is the first open source Supernode: a complete stack for enterprises to build and scale secure Web3 applications. The FireFly API for digital assets, data flows, and blockchain transactions makes it radically faster to build production-ready apps on popular chains and protocols.
https://hyperledger.github.io/firefly
Apache License 2.0
508 stars 209 forks source link

Fix golangci issues #1478

Closed alex-semenyuk closed 7 months ago

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.96%. Comparing base (577e8c4) to head (46d0f40).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1478 +/- ## ========================================== - Coverage 99.99% 99.96% -0.03% ========================================== Files 322 322 Lines 23406 23406 ========================================== - Hits 23404 23397 -7 - Misses 1 6 +5 - Partials 1 3 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nguyer commented 8 months ago

Hi @alex-semenyuk, thanks for opening this.

Golangci already runs as a part of the existing make build job here: https://github.com/hyperledger/firefly/blob/577e8c47680c6230209a74829921a9c427766af8/Makefile#L15-L16

Is there something that this is not catching that you are trying to fix?

alex-semenyuk commented 8 months ago

@nguyer Thanks for pointing, then it's suspicious that it doesn't detect all https://github.com/hyperledger/firefly/actions/runs/8213258671/job/22464445082