search

hyperledger / firefly

Hyperledger FireFly is the first open source Supernode: a complete stack for enterprises to build and scale secure Web3 applications. The FireFly API for digital assets, data flows, and blockchain transactions makes it radically faster to build production-ready apps on popular chains and protocols.
https://hyperledger.github.io/firefly
Apache License 2.0
508 stars 209 forks source link

Fix broken links at docs #1489

Closed alex-semenyuk closed 7 months ago

nguyer commented 7 months ago

@alex-semenyuk All of these links work for me when I browse to https://hyperledger.github.io/firefly/head/tutorials/custom_contracts/ and https://hyperledger.github.io/firefly/head/tutorials/custom_contracts/pinning.html. Is there something that is flagging them as broken?

alex-semenyuk commented 7 months ago

This html links don't work on github https://github.com/hyperledger/firefly/blob/main/docs/tutorials/broadcast_data.html Is it ok? It seems like there are mix of links - some of them ends with html like https://github.com/hyperledger/firefly/blob/main/docs/tutorials/broadcast_data.html; some of them ends with md like https://github.com/hyperledger/firefly/blob/main/docs/tutorials/custom_contracts/ethereum.md (then it works on github as well)

nguyer commented 7 months ago

This html links don't work on github https://github.com/hyperledger/firefly/blob/main/docs/tutorials/broadcast_data.html Is it ok?

Ah okay. The docs site is generated by Jekyll and takes all of these files in and generates static HTML for them. So these links do actually work on the real docs site. I don't generally browse the docs right in GitHub as there are lots of things like tables of contents and external file embeds that don't show up there.

However, I'm happy to merge this, because it should not make any difference to the generated docs site, and it does improve the GitHub experience. Thanks.