search

hyperledger / firefly

Hyperledger FireFly is the first open source Supernode: a complete stack for enterprises to build and scale secure Web3 applications. The FireFly API for digital assets, data flows, and blockchain transactions makes it radically faster to build production-ready apps on popular chains and protocols.
https://hyperledger.github.io/firefly
Apache License 2.0
507 stars 208 forks source link

Adding check URLs to GH actions #1518

Closed dwertent closed 3 months ago

dwertent commented 6 months ago

I've noticed some invalid URLs in the repository. This GitHub Action will help detect these invalid URLs when opening a pull request or during a scheduled scan. I recommend setting force_pass to false to prevent the approval of pull requests containing invalid URLs. You can see an example here.

image

dwertent commented 6 months ago

Working on this PR made me realize that the package should support SARIF format output. As a result, I opened this PR and this PR to enhance the informativeness of the GitHub Action results.

EnriqueL8 commented 4 months ago

I can't edit my review seems like you put in your description I recommend setting force_pass to false to prevent the approval of pull requests containing invalid URLs. that is valid to me then