search

hyperledger / governance

https://hyperledger.github.io/governance/
Apache License 2.0
9 stars 23 forks source link

Change repo ACL for fabric-chaincode-java #256

Closed bestbeforetoday closed 4 months ago

bestbeforetoday commented 4 months ago
bestbeforetoday commented 4 months ago

Alternatively, if it's not desirable to grant this level of access, please ensure that the branch protection settings for the main (or default * rule, if that applies to the main branch) have:

  1. Require status checks to pass before merging pull requests
  2. Pull request success as a required check
  3. Dismiss stale pull request approvals when new commits are pushed
ryjones commented 4 months ago

Hi, Please file a PR here, probably to either create a new team or to add yourself to the fabric-admins team.

@mbwhite @denyeart

bestbeforetoday commented 4 months ago

@ryjones Is this not what the existing fabric-chaincode-java-maintainers team is for? Should I just raise a PR to move myself from member to maintainer there?

bestbeforetoday commented 4 months ago

To perhaps answer my own question, there are several repositories where I do have full access to the repository settings but I am only listed as a member rather than a maintainer in access-control.yaml. I guess this means that changing the category for my ID in that file will not necessarily grant the required access. Or at least there are other mechanisms in use to control GitHub repository roles for specific IDs. Anyway, just let me know what I need to do.

bestbeforetoday commented 4 months ago

OK, I think I figured it out. See linked pull request. Let me know if anything needs to be changed.

I guess I can make at least some of the changes required in a .github/settings.yml file, but without the settings already there I can't check what's currently configured. It also seems more error-prone when setting required checks for PRs, and a mistake there might prevent any PRs being merged to correct the error. I can try that route if you prefer though.