fix: KeyID from String to Opaque Type and presentation job cleanup

mineme0110 commented 2 weeks ago

Description:

making KeyId type safe and general cleanup of unused functions

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

[ X] My PR follows the contribution guidelines of this project
[ X] My PR is free of third-party dependencies that don't comply with the Allowlist
[ X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

github-actions[bot] commented 2 weeks ago

Unit Test Results

96 files ±0 96 suites ±0 22m 30s :stopwatch: +13s 826 tests ±0 818 :white_check_mark: ±0 8 :zzz: ±0 0 :x: ±0 833 runs ±0 825 :white_check_mark: ±0 8 :zzz: ±0 0 :x: ±0

Results for commit 6b736ed1. ± Comparison against base commit 8bc2018b.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 weeks ago

Integration Test Results

15 files ±0 15 suites ±0 2s :stopwatch: ±0s 33 tests ±0 33 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 46 runs ±0 46 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit 6b736ed1. ± Comparison against base commit 8bc2018b.

:recycle: This comment has been updated with latest results.

hyperledger / identus-cloud-agent