feat: restrict CORS to first applicationUrl

hyperledger / identus-cloud-agent

Identus Cloud Agent

https://docs.atalaprism.io/

Apache License 2.0

72 stars 18 forks source link

feat: restrict CORS to first applicationUrl #1230

Open womfoo opened 3 days ago

womfoo commented 3 days ago

Description:

If CORS is enabled, set allow_origins: to the first applicationUrl if unspecified

Checklist:

[x] My PR follows the contribution guidelines of this project
[x] My PR is free of third-party dependencies that don't comply with the Allowlist
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked the PR title to follow the conventional commit specification

github-actions[bot] commented 3 days ago

Integration Test Results

16 files ±0 16 suites ±0 2s :stopwatch: ±0s 34 tests ±0 34 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 59 runs ±0 59 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit fc5707dc. ± Comparison against base commit e5e34113.

github-actions[bot] commented 3 days ago

Unit Test Results

96 files ±0 96 suites ±0 23m 13s :stopwatch: +46s 826 tests ±0 818 :white_check_mark: ±0 8 :zzz: ±0 0 :x: ±0 833 runs ±0 825 :white_check_mark: ±0 8 :zzz: ±0 0 :x: ±0

Results for commit fc5707dc. ± Comparison against base commit e5e34113.

yshyn-iohk commented 3 days ago

@womfoo, if you add [skip ci] to the end of the PR name, the tests will not be executed and you shouldn't wait for 30 minutes