Closed patlo-iog closed 1 month ago
:rocket: Merge success
20 files ±0 20 suites ±0 2s :stopwatch: ±0s 45 tests ±0 45 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 71 runs ±0 71 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit d41aeb9d. ± Comparison against base commit 3a7984b1.
:recycle: This comment has been updated with latest results.
98 files +1 98 suites +1 23m 36s :stopwatch: + 1m 2s 837 tests +5 829 :white_check_mark: +5 8 :zzz: ±0 0 :x: ±0 844 runs +5 836 :white_check_mark: +5 8 :zzz: ±0 0 :x: ±0
Results for commit d41aeb9d. ± Comparison against base commit 3a7984b1.
:recycle: This comment has been updated with latest results.
@mattklepp thanks for a review. Yes, some of those are from example json in the spec (like this one https://identity.foundation/presentation-exchange/spec/v2.1.1/#presentation-definition---minimal-example-3)
rr### Description: Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable. Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR.
Alternatives Considered (optional):
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist: