feat: Add KID to the credential-offers API - ATL-7704

hyperledger / identus-cloud-agent

Identus Cloud Agent

https://identus.io/

Apache License 2.0

79 stars 21 forks source link

feat: Add KID to the credential-offers API - ATL-7704 #1320

Closed FabioPinheiro closed 1 week ago

FabioPinheiro commented 3 weeks ago

Description:

feat: Add KID to the credential-offers API - ATL-7704

Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

github-actions[bot] commented 3 weeks ago

Unit Test Results

100 files ±0 100 suites ±0 15m 41s :stopwatch: -9s 860 tests ±0 852 :white_check_mark: ±0 8 :zzz: ±0 0 :x: ±0 867 runs ±0 859 :white_check_mark: ±0 8 :zzz: ±0 0 :x: ±0

Results for commit ec12fb58. ± Comparison against base commit 65679503.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 weeks ago

Integration Test Results

20 files ±0 20 suites ±0 2s :stopwatch: ±0s 45 tests ±0 45 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 71 runs ±0 71 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit ec12fb58. ± Comparison against base commit 65679503.

:recycle: This comment has been updated with latest results.

FabioPinheiro commented 3 weeks ago

For the tests to be passing ATM means there is a lack of tests

FabioPinheiro commented 2 weeks ago

I messed up the rebase I'm still trying to fix it

coveralls commented 2 weeks ago

Changes unknown when pulling ec12fb58e4f99f68835a26da298296f17c251014 on feat/ATL-7704-add-KID-to-the-credential_offers-API into on main.

patlo-iog commented 1 week ago

:rocket: Merge success