hyperledger / identus-edge-agent-sdk-swift

https://hyperledger.github.io/identus-edge-agent-sdk-swift/documentation/edgeagentsdk

Apache License 2.0

10 stars 5 forks source link

fix: bug with header and footer of ed25519 and x25519 pem keys #109

Closed goncalo-frade-iohk closed 9 months ago

goncalo-frade-iohk commented 9 months ago

Overview

Keys header and footer were EC PRIVATE KEY/EC PUBLIC KEY when they should be just PRIVATE KEY/PUBLIC KEY

Fixes ATL-6291

Checklist

My PR contains...

[ ] No code changes (changes to documentation, CI, metadata, etc.)
[x] Bug fixes (non-breaking change which fixes an issue)
[ ] Improvements (misc. changes to existing features)
[ ] Features (non-breaking change which adds functionality)

My changes...

[ ] are breaking changes
[x] are not breaking changes
[ ] If yes to the above: I have updated the documentation accordingly

Documentation

[x] My changes do not require a change to the project documentation
[ ] My changes require a change to the project documentation
[ ] If yes to the above: I have updated the documentation accordingly

Tests

[ ] My changes can not or do not need to be tested
[ ] My changes can and should be tested by unit and/or integration tests
[ ] If yes to the above: I have added tests to cover my changes
[ ] If yes to the above: I have taken care to cover edge cases in my tests

goncalo-frade-iohk commented 9 months ago

@hamada147 they are indeed part of Curve25519 and part of EC, but the rules are not the same. You can check that on the RFC 8410 that specifies identifiers including in a PEM file. ;)

https://datatracker.ietf.org/doc/html/rfc8410