hyperledger / identus-edge-agent-sdk-swift

https://hyperledger.github.io/identus-edge-agent-sdk-swift/documentation/edgeagentsdk
Apache License 2.0
10 stars 5 forks source link

fix: Update Package.swift to use HTTPS for swift-protobuf dependency #147

Closed GavinPlusPlus closed 3 months ago

GavinPlusPlus commented 3 months ago

Description:

Hey there, this is just a simple change that I made to help fix the setup on my mac for cloning the sample project. Both my friend (@Jack-Severson) and I were having issues with building the demo wallet app in Xcode 15.4 or adding the package to a new project due to an issue with fetching swift-protobuf.

I ultimately narrowed the issue down to the Package.swift file using the SSH format for cloning the swift-protobuf package and timing out on our machines. I changes the the format to HTTPS and was then able to successfully resolve dependencies and build the app.

Checklist:

goncalo-frade-iohk commented 3 months ago

Hey @GavinPlusPlus. Yes sometimes Xcode has problems with ssh. I will merge this today ;)

goncalo-frade-iohk commented 3 months ago

@GavinPlusPlus Im merging without build completed, the build issue is just because of the PR being from a user that doesn't have access to the secrets. But I tested the PR and it works as expected.