fix: add compliant dates not in ms, but in seconds. - Githubissues

hyperledger / identus-edge-agent-sdk-ts

Apache License 2.0

15 stars 8 forks source link

fix: add compliant dates not in ms, but in seconds. #206

Closed elribonazo closed 2 months ago

elribonazo commented 2 months ago

Description:

In our current 2.12 release we have introduced multiple breaking changes into the JWT classes and https://github.com/input-output-hk/atala-prism-wallet-sdk-ts/pull/175 that PR now has some conflicts.

The JWT specification states issuance and expiration dates as numbers, and we were generating dates using the number of seconds not ms

Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

github-actions[bot] commented 2 months ago

Lines	Statements	Branches	Functions
	72.77% (2072/2847)	61.53% (947/1539)	79.05% (570/721)

JUnit

Tests	Skipped	Failures	Errors	Time
434	6 :zzz:	0 :x:	0 :fire:	1m 5s :stopwatch: