fix: attachment descriptor parameters

[amagyar-iohk]

Description:

While debugging the repeated message from Mediator we found out the cause of it. This PR fixes this long time issue. Fixes ATL-7354

Unit tests:

Integration tests:

Checklist:

• [x] My PR follows the contribution guidelines of this project
• [x] My PR is free of third-party dependencies that don't comply with the Allowlist
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] I have checked the PR title to follow the conventional commit specification

[github-actions[bot]]

Lines	Statements	Branches	Functions
	75.29% (2785/3699)	65.05% (1355/2083)	80.55% (721/895)

JUnit

Tests	Skipped	Failures	Errors	Time
504	6 :zzz:	0 :x:	0 :fire:	1m 16s :stopwatch:

[FabioPinheiro]

He added some logic to filter the messages locally. I'm IMO that should be removed

On Sat, Jun 29, 2024, 18:35 Allain Magyar @.***> wrote:

@.**** commented on this pull request.

In src/mercury/didcomm/Wrapper.ts https://github.com/input-output-hk/atala-prism-wallet-sdk-ts/pull/240#discussion_r1659914303 :

   attachment.media_type,

• attachment.id,

Which workaround?

— Reply to this email directly, view it on GitHub https://github.com/input-output-hk/atala-prism-wallet-sdk-ts/pull/240#discussion_r1659914303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIPJNA73IAHUK3GZDKV2TZJ3V45AVCNFSM6AAAAABKCRFUPWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBZG42DCMBYHE . You are receiving this because you commented.Message ID: <input-output-hk/atala-prism-wallet-sdk-ts/pull/240/review/2149741089@ github.com>

[mkbreuningIOHK]

@amagyar-iohk , as you are mentioning This PR fixes this long time issue: Could you give the reference to the issue (GitHub or Jira) so we can track? cc @FabioPinheiro

[FabioPinheiro]

I believe the issue was never reported

On Mon, Jul 1, 2024, 06:49 mkbreuning @.***> wrote:

@amagyar-iohk https://github.com/amagyar-iohk , as you are mentioning This PR fixes this long time issue: Could you give the reference to the issue (GitHub or Jira) so we can track? cc @FabioPinheiro https://github.com/FabioPinheiro

— Reply to this email directly, view it on GitHub https://github.com/input-output-hk/atala-prism-wallet-sdk-ts/pull/240#issuecomment-2199290406, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDIPJMQKNJLMZ4JW2Z2ILLZKDUYPAVCNFSM6AAAAABKCRFUPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJZGI4TANBQGY . You are receiving this because you were mentioned.Message ID: @.*** com>

[elribonazo]

@mkbreuningIOHK I assume that we have introduced this duplicity issue recently and because we have not released in a long period this is probably not an issue outside.

But during my tests in the latest version i did see that there was some duplicate messages.

+1 to merge this PR @amagyar-iohk all good