fix: improve didcomm error handling through Mercury and edge agent he… - Githubissues

hyperledger / identus-edge-agent-sdk-ts

Apache License 2.0

24 stars 13 forks source link

fix: improve didcomm error handling through Mercury and edge agent he… #257

Closed elribonazo closed 2 months ago

elribonazo commented 4 months ago

Description:

Improves error handling for didcomm messages when the mediator url is invalid.

Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

github-actions[bot] commented 4 months ago

Lines	Statements	Branches	Functions
	75.24% (2785/3701)	64.98% (1355/2085)	80.55% (721/895)

JUnit

Tests	Skipped	Failures	Errors	Time
504	6 :zzz:	0 :x:	0 :fire:	1m 13s :stopwatch:

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 10022945927

Details

7 of 14 (50.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 71.474%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/mercury/Mercury.ts	0	3	0.0%
src/edge-agent/helpers/ApiImpl.ts	7	11	63.64%
<!--	Total:	7	14	50.0%	-->

Totals
Change from base Build 10009455037:	-0.03%
Covered Lines:	2719
Relevant Lines:	3615

💛 - Coveralls