feat: errors introducing error codes and refactoring Apollo errors - Githubissues

hyperledger / identus-edge-agent-sdk-ts

Apache License 2.0

24 stars 13 forks source link

feat: errors introducing error codes and refactoring Apollo errors #265

Closed curtis-h closed 3 months ago

curtis-h commented 3 months ago

Description:

Starting to align errors between the SDKS

introcucing Error Codes
refactoring Apollo errors to use codes

Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

github-actions[bot] commented 3 months ago

Lines	Statements	Branches	Functions
	75.74% (2795/3690)	65.73% (1362/2072)	80.62% (720/893)

JUnit

Tests	Skipped	Failures	Errors	Time
513	6 :zzz:	0 :x:	0 :fire:	54.946s :stopwatch:

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10453764445

Details

38 of 56 (67.86%) changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 72.08%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/apollo/utils/Ed25519PrivateKey.ts	0	1	0.0%
src/domain/models/keyManagement/Key.ts	0	1	0.0%
src/apollo/utils/derivation/DerivationPath.ts	9	11	81.82%
src/domain/utils/hash.ts	6	8	75.0%
src/apollo/utils/Secp256k1PrivateKey.ts	1	4	25.0%
src/apollo/Apollo.ts	18	27	66.67%
<!--	Total:	38	56	67.86%	-->

Totals
Change from base Build 10453613381:	0.2%
Covered Lines:	2730
Relevant Lines:	3605

💛 - Coveralls