hyperledger / identus-edge-agent-sdk-ts

Apache License 2.0
24 stars 13 forks source link

fix: improve parseInvitation to handle parsing oob properly #280

Closed elribonazo closed 2 months ago

elribonazo commented 2 months ago

Description:

Improvement in order to keep SDK's aligned, we are able to use parseOOBInvitation with the URL object directly or the standard parseInvitation with the uri string + added test coverage

  1. agent.parseOOBInvitation(new URL(validOOB))
  2. agent.parseInvitation(validOOB) //as string

Checklist:

github-actions[bot] commented 2 months ago
Lines Statements Branches Functions
Coverage: 76%
76.26% (2860/3750) 65.91% (1402/2127) 81.1% (734/905)

JUnit

Tests Skipped Failures Errors Time
528 6 :zzz: 0 :x: 0 :fire: 55.675s :stopwatch:
coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10664806424

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/edge-agent/Agent.Invitations.ts 11 13 84.62%
src/edge-agent/protocols/invitation/v2/DIDCommInvitationRunner.ts 14 17 82.35%
<!-- Total: 28 33 84.85% -->
Totals Coverage Status
Change from base Build 10662917238: 0.2%
Covered Lines: 2795
Relevant Lines: 3665

💛 - Coveralls
elribonazo commented 2 months ago

Closed as some parallel work is being led by @curtis-h