hyperledger / identus-edge-agent-sdk-ts

Apache License 2.0
24 stars 13 forks source link

Commits missing from `main` #297

Closed mixmix closed 1 month ago

mixmix commented 1 month ago

Opening a PR I noticed that some commits are outside of the main branch history:

git log --graph --oneline --all
* 9109173 (origin/main, main) test: adds dispatch to integration repo (#296)
| * afa8eab (origin/feature/pi7-demo) fix: improvements
| * 62234d8 fix: wip
| * c906ccb fix: simplify styles
| * fcef0f5 fix: implement pi7 wrapper for Doctor and Pharmacy
|/
| * dc70a65 (origin/docs/oidc_and_connectionless) docs: OIDC and ConnectionlessOffer examples
|/
* 97e05e7 feat: Connectionless Offer (#293)
* 295e14f feat: OIDC Agent (#278)
| * 6bfbac2 (origin/feature/ATL-6454) fix: improve disclosure
| * 2bad82f fix: linter improvements
| * 4556ce4 fix: improve code as per cristian feedback on the PR
| * 3b4e14b fix: improving test scenarios and code quality
| * f737c47 feat: add edge agent sd+jwt verification
|/
* e569d79 fix: e2e cucumber import (#291)
* bcbd355 chore: update e2e readme (#286)
* 02430db feat: integrating error reporting protocol  (#289)
* f53d728 fix: sdk module resolution issues (#290)
* 54ead35 fix: next generation building tools and testing framework (#258)
* 3a8fd66 feat: separate DIDCommAgent and adding Tasks (#277)
* 2f83633 ci: fixes release script (#288)
| * d8d84e6 (tag: v6.1.0, origin/release/6.1.0) chore(release): release 6.1.0
| * 4715781 ci: fixes release script (#288)
|/
* 7ac3c2d ci: update release config (#285)
* b8409af fix: update code-owners (#281)
* fabcc2c fix: noble-ciphers dependency (#284)
* 2c7336a ci: set action to use node lts (#283)
* 5042d79 ci: removes @hyperledger scope auth (#282)
* c9ae715 test: fixes cloud-agent client in e2e (#249)
| * b030696 (origin/feature/ATL-7683) fix: improve VC types by creating data model and corresponding types for v1 and v2 feat: integrate functionality in JWTVerifiableCredential to support VC Data model v1 and v2
|/
* a6a72ff fix: main branchname in semantic release config (#279)
* bd64547 docs: corrected Edge Agent SDK KMP repo URL (#276)
* 4291274 docs: link pluto-encrypted as reference implementation (#250)
* 82a50d3 fix: package dependencies found by mixmix (#273) (#275)
* d43ec60 feat: Connectionless presentation (#272)
* dce65b5 fix: bitstring improvement and test coverage (#270)
* 8a1ed3f feat: decoupling JWT from Pollux and adding KID header to JWTs (#271)
* da27890 docs: fix links in README (#252)
* f99c565 feat: errors introducing error codes and refactoring Apollo errors (#265)
* 7e563b8 chore: update Apollo lib to latest version (#266)
* 2397ebe refactor: Api from axios to fetch (#268)
* 9ea9d42 fix: rollup is not a optionalDependency, and is not included in our m… (#269)
* 460102a fix: external build update for new generated code (#264)
* 0d09ea7 fix: nextjs demo safeBody (#263)
* 99df3c0 fix: make mediator updateable in the nextjs demo (#262)
* 8a818ad docs: add commit signing notes to CONTRIBUTING (#259)
* 2ad0d8a (tag: v6.0.1) fix: use for-loops in Pluto persistence methods (#261)

In particular I was surprised:

| * d8d84e6 (tag: v6.1.0, origin/release/6.1.0) chore(release): release 6.1.0
| * 4715781 ci: fixes release script (#288)
mixmix commented 1 month ago

standing on main it looks like 4715781 has not been dropped?

git checkout main
git diff 4715781 publish.sh

So perhaps this is not a bug, but I was worried it was....

elribonazo commented 1 month ago

That is due to our release system, we need to better configure semantic-release which is planned. With the current setup, we cannot leave more than 1 active release branch that forces us to remove release branches and commits get orphaned.

As soon as tags are not removed though everything should be okey and they cannot be removed