fix: build single commonjs output while keeping ability to use import or require

elribonazo commented 3 weeks ago

Description:

Fixes https://github.com/hyperledger/identus-edge-agent-sdk-ts/issues/319 by only building a commonjs module while still maintaining the ability to import from esm (import) or commonjs (require) due to some constraints in our build process the external wasm packages don't get converted into esm correctly and it is not worth going deeper at the moment

Alternatives Considered (optional):

I searches esbuild documentations and tries to hack the build around without luck

Checklist:

[x] My PR follows the contribution guidelines of this project
[x] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked the PR title to follow the conventional commit specification

github-actions[bot] commented 3 weeks ago

Lines	Statements	Branches	Functions
	76.07% (3632/4774)	66.49% (1665/2504)	80.29% (864/1076)

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11633217176

Details

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 72.549%

Files with Coverage Reduction	New Missed Lines	%
src/domain/utils/DER.ts	3	35.14%
<!--	Total:	3		-->

Totals
Change from base Build 11615245352:	-0.06%
Covered Lines:	3523
Relevant Lines:	4647

hyperledger / identus-edge-agent-sdk-ts