Added a way to not use the -it mode for docker easily by setting the CM env variable on run #13

hyperledger / indy-node-monitor

Apache License 2.0

13 stars 27 forks source link

Added a way to not use the -it mode for docker easily by setting the CM env variable on run #13 #15

Closed swcurran closed 4 years ago

swcurran commented 4 years ago

Addresses #13 -- @lohanspies . However, I'm not sure we need the -it at all. @WadeBarnes -- can we just leave off the -it, since all we do is write the output to standard out?

lohanspies commented 4 years ago

@swcurran Suggest we make the default mode to run without -it i.e. cron mode and then change the parameter to DM (Developer Mode) that will enable the developer to attach to bash shell where needed. If this will never be a requirement then it might as well just be removed completely.

WadeBarnes commented 4 years ago

The -it in run.sh is not required, it can be removed completely.

swcurran commented 4 years ago

Will do.

swcurran commented 4 years ago

I turned it off by default, but left the "IM" (interactive mode) env variable that if set turns on interactive mode. That might be unneeded, but hey, why not?