hyperledger / indy-node-monitor

Apache License 2.0
13 stars 27 forks source link

Add node counts to status when using network monitor DID #20

Closed swcurran closed 3 years ago

swcurran commented 4 years ago

When not in anonymous mode, suggest that the --status result also return the following fields:

From Pool_info:

From Hardware:

Nice to have from the 'Extractions' node -- trickier because the values are in text:

swcurran commented 4 years ago

Note that I would like those values in all cases, so we can just feed the numbers into a graph and see how the change.

WadeBarnes commented 4 years ago

I'll think about this a bit. The purpose of --status was to provide more of a green/red light status summary of the node. Unreachable nodes (counts and list), for instance, are surfaced when detected, otherwise all nodes are reachable. I agree with adding Suspicious_nodes to the issue detection. That said detected issues (and the status summary) are available regardless of whether you get the full results or opt for just the status summary using --status.

Right now it feels like a monitoring system that is tracking/graphing these metrics (or any metrics) historically should be sourcing the data from the full results and not using --status.

swcurran commented 4 years ago

Fair enough. Feel free to close this if we're not going to do it. For me it was worth the exercise of going through the response is detail.