Add validator client and node public addresses

hyperledger / indy-node-monitor

Apache License 2.0

13 stars 27 forks source link

Add validator client and node public addresses #22

Closed WadeBarnes closed 4 years ago

WadeBarnes commented 4 years ago

Add the public client and node addresses to the output of fetch-validator-status.
- The public addresses come from the pool information. The nodes themselves are unaware of their public addresses. The addresses are added to the node summary in order to ensure the results from get_validator_info are unmodified.
- Requires a version of bcgovimages/von-image:next-1 built with https://github.com/hyperledger/indy-vdr/commit/ce0e7c42491904e0d563f104eddc2386a52282f7. The address fields will not be included in the summary results when using a previous version of bcgovimages/von-image:next-1.

Signed-off-by: Wade Barnes wade.barnes@shaw.ca

WadeBarnes commented 4 years ago

Changes have been tested using the existing version and a new (locally built) version of bcgovimages/von-image:next-1. Results have been verified against the records for Sovrin BuilderNet, StagingNet, and MainNet ledgers.

WadeBarnes commented 4 years ago

PR and request for new build of bcgovimages/von-image:next-1; https://github.com/PSPC-SPAC-buyandsell/von-image/pull/23

WadeBarnes commented 4 years ago

Related indy-vdr ticket and PR;

WadeBarnes commented 4 years ago

Example output:

  {
    "name": "FoundationBuilder",
    "client-address": "tcp://35.161.146.16:9702",
    "node-address": "tcp://50.112.53.5:9701",
    "status": {
      "ok": true,
      "uptime": "39 days, 1:55:36",
      "timestamp": 1601229678,
      "software": {
        "indy-node": "1.12.4",
        "sovrin": "1.1.89"
      }
    }
  }

WadeBarnes commented 4 years ago

The new bcgovimages/von-image:next-1 image is available ; https://hub.docker.com/r/bcgovimages/von-image/tags

WadeBarnes commented 4 years ago

To ensure the new version of bcgovimages/von-image:next-1 delete any locally cached version; docker image rm bcgovimages/von-image:next-1

swcurran commented 4 years ago

Suggest adding an error status check on the docker build and terminating on fail. I've been running the command from the parent directory, and the docker build has been failing, but the app running fine (because of the existing image). The command would run fine but I didn't get the update because even though I deleted the base image, the built image still remained.

Anyway, once that was sorted out -- all good. :-).