search

hyperledger / indy-node-monitor

Apache License 2.0
13 stars 28 forks source link

Build docker #78

Closed GuillaumeBourque-QC closed 1 month ago

GuillaumeBourque-QC commented 1 month ago

Hello this as not been tested but should be near a working solution.

Since the idlab depot is not updated very often we could host a docker image right in GitHub container registry.

In order to use this workflow we need to add a tag to a release like so:

git tag v2.4.5
git push origin v2.4.5

The resulting container is not public but from my readings, this cli (gh) if you have it can make the container publicly avail,

gh api --method PATCH /user/packages/container/hyperledger/indy-node-monitor/visibility --input '{"visibility":"public"}'
GuillaumeBourque-QC commented 1 month ago

No problem at all using the default action which I was not aware of (I only look at https://docs.github.com/packages/working-with-a-github-packages-registry/working-with-the-container-registry and some googling).

Do you want to to change the workflow with your proposition ? Since we are working in gitlab internally it may be easier for you to test from your repos, or if time is missing I can try to look at it next week ?

WadeBarnes commented 1 month ago

No problem at all using the default action which I was not aware of (I only look at https://docs.github.com/packages/working-with-a-github-packages-registry/working-with-the-container-registry and some googling).

Do you want to to change the workflow with your proposition ? Since we are working in gitlab internally it may be easier for you to test from your repos, or if time is missing I can try to look at it next week ?

You should be able to test any changes you make, easily, on your fork in GitHub.

GuillaumeBourque-QC commented 1 month ago

Hello Wade,

I tested some of the provided example but seem more complicated and dont see the value for this repos.

Also from GitHub Action examples that you can see when you create from their template they all use docker build.

image

So I did several test and came up with a working solution based on tags. you can run manually the workflow and provide a tag version or it will build on the latest tag.

Maybe we could start from this ? I will push my code in a few minutes ?

GuillaumeBourque-QC commented 1 month ago

I can't get out of this because of 1 commit which is not sign even if I did tried to sing all my commit, it's friday night here, will continue next week...

Maybe I'll close this PR an open a new one for simplicity and to avoid all these comit.

GuillaumeBourque-QC commented 1 month ago

Will continue in the new PR https://github.com/hyperledger/indy-node-monitor/pull/80