search

hyperledger / indy-node-monitor

Apache License 2.0
13 stars 28 forks source link

First draft of helm chart with prmetheus and alertmanager as optionals #79

Open GuillaumeBourque-QC opened 1 month ago

GuillaumeBourque-QC commented 1 month ago

This code will allow to deploy the indy-node-monitor solution in OpenShift or K8s.

All the dashboards and alerts are relying on influxdb only. So even if you enable prometheus it wont be used by the dashbaord but will be available.

It's a functionnal first draft, since I'm not a k8s expert I may have miss some best practice.

All feedback will be appreciated.

WadeBarnes commented 1 month ago

Took a very quick cursory pass over the changes.

You shouldn't need to define and manage any routes, such as charts/templates/grafana/route.yml, you should just be able to define ingresses. OpenShift will auto-generate and manage any necessary routes when you provision a k8s ingress.

When properly setup OpenShift will manage the route and it's properties for any k8s ingress you define, including management of any TLS certificates defined on the ingress. Changes to the tls secret for the ingress will be reflected on the route.

I believe this is accomplished by defining ingressClassName in the ingress and setting it to default, setting it to "". OpenShift should then translate that to openshift-default and auto-generate a managed route. The managed route will contain an ownerReferences section to the associated ingress.

GuillaumeBourque-QC commented 1 month ago

Thanks, I don't have much view on how OpenShift is configured (no rights at all) and not much deep knowledge, but when I did try the ingress way it never worked for me and I was suggested to use a route which was working for other projects.

That's why I made this choice as optional, you can specify one or the other depending on you needs in the values.yaml file