hyperledger / indy-node

The server portion of a distributed ledger purpose-built for decentralized identity.
https://wiki.hyperledger.org/display/indy
Apache License 2.0
685 stars 657 forks source link

Make node_control_utils.hold_packages more robust. #1742

Open WadeBarnes opened 2 years ago

WadeBarnes commented 2 years ago

The /indy_node/utils/node_control_utils.py, hold_packages method will cause the indy-node-control service to crash when it attempts to hold a package that is not installed on the system. This also causes the indy-node service to restart.

Add some error handling to the code so the method will simply log the fact that it tried to hold a package that does not exist rather than erroring out and causing the indy-node-control service to crash.

References:

ggold7046 commented 1 year ago

Hi @WadeBarnes, I'm new to Hyperledger and oss. Could you please tell me the problem in details and guide me how to solve this ?