search

hyperledger / indy-node

The server portion of a distributed ledger purpose-built for decentralized identity.
https://wiki.hyperledger.org/display/indy
Apache License 2.0
685 stars 657 forks source link

fix importlib-metadata dependency #1748

Closed mgmgwi closed 2 years ago

mgmgwi commented 2 years ago

This should fix the wrong dependency in the indy-node .deb package.

The following packages have unmet dependencies: indy-node : Depends: importlib-metadata (< 3.0) but it is not installable

Signed-off-by: mgmgwi guido.wischrop@mgm-tp.com

sovbot commented 2 years ago

Can one of the admins verify this patch?

WadeBarnes commented 2 years ago

Thanks @mgmgwi. @udosson, @pSchlarb, this PR is relying on the fact that indy-plenum is building and publishing this particular 3rd party package; https://github.com/hyperledger/indy-plenum/blob/ubuntu-20.04-upgrade/build-scripts/ubuntu-2004/build-3rd-parties.sh#L106. How do we feel about this implicit dependency? Perhaps a comment in the prepare package script would be enough.

pSchlarb commented 2 years ago

Hm since version setting is also commented in plenum, i see no problem with that so far. IMHO a comment should be sufficient and wouldn't hurt.

udosson commented 2 years ago

I'd rather add the comment to setup.py because we don't need to change the prepare-package.sh script

mgmgwi commented 2 years ago

I removed the sed replacement in build-scripts/ubuntu-2004/prepare-package.sh#L34 as requested by @udosson in the comment above.

udosson commented 2 years ago

@mgmgwi - thank you for the changes. I'll test the build and install process on Tuesday and will merge after the successful testing.

mgmgwi commented 2 years ago

I talked with @udosson and for now, we have to add the python3 prefix in prepare-package.sh. I updated the file accordingly.

udosson commented 2 years ago

Thanks for adjusting the PR according to our discussion, @mgmgwi

We need to at the python3- prefix in prepare-package.sh. However, I cannot say at the moment why we don't need this in Indy Plenum. I'll do further investigations and please let me know your thoughts @WadeBarnes and @pSchlarb if you have an idea.

WadeBarnes commented 2 years ago

Thanks for adjusting the PR according to our discussion, @mgmgwi

We need to at the python3- prefix in prepare-package.sh. However, I cannot say at the moment why we don't need this in Indy Plenum. I'll do further investigations and please let me know your thoughts @WadeBarnes and @pSchlarb if you have an idea.

Perhaps an oversight.