Open WadeBarnes opened 2 years ago
The indicated discrepancy in the documentation may actually be a bug in the code. The initial code associated to the above indicated changes happened here, https://github.com/hyperledger/indy-node/commit/8d505a919dc13170a33ef99603d8ef0c921e5b19, and is associated with this Jira ticket, https://jira.hyperledger.org/browse/INDY-1554. The acceptance criteria for the ticket (in both settings cases) indicates the owner of the REVOC_REG_DEF
should be allowed to write new REVOC_REG_ENTRY
s.
First step would be to determine if this particular discrepancy is a bug or intentional.
@mac-arrap, @VladimirWork, Do either of you recall this work?
So what I remember is that this went through a lot of review by the evernym team but we didn't change the documentation. But I would feel a lot more comfortable if @ashcherbakov would confirm.
@mac-arrap, What's throwing me off right now is the acceptance criteria of the jira ticket matches what is indicated in the auth_rules documentation, but it does not match the default auth_rule (included above) that was implemented in the code.
The Default AUTH_MAP Rules document, although mostly accurate, does not fully reflect the default auth rules of a new indy-node network.
One example is the
REVOC_REG_ENTRY ADD
rule. The document states the owner of the correspondingREVOC_REG_DEF
, regardless of role, can add newREVOC_REG_ENTRY
s. The default auth_rules for the network on the other hand, indicate you need to be the owner of the correspondingREVOC_REG_DEF
and have a signature from a Trustee, Steward, or Endorser.Taken from a new network:
It appears the rule for adding a new
REVOC_REG_ENTRY
was updated in mid 2019, but the documentation was not updated to reflect the change in code.