git diff origin/stable..origin/ubuntu-20.04-upgrade

[KimEbert42]

I went through the output of:

git diff origin/stable..origin/ubuntu-20.04-upgrade

And determined things that may require further review.

See gist for complete review

https://gist.github.com/reflectivedevelopment/f7b1f8ab8fae6dab96dccb3627fde316

I believe the following need to be reviewed. It is likely that many of these changes are fine, but with git history I wasn't able to determine if anything was lost or not in the move to ubuntu 20.04.

• [ ] .flake8

This is a minor cody styling issue, but I think would be valuable to keep.

index 85491324..3e3a277c 100644
--- a/.flake8
+++ b/.flake8
@@ -1,5 +1,5 @@
 [flake8]
-ignore = N801, N802, N803, N806, N813, C901, E501, F401, E741
+ignore = N801, N802, N803, N806, N813, C901, E501, F401, W605
 exclude =
     # common places
     .git,__pycache__,docs/source/conf.py,old,build,dist,environment

• [ ] data/migrations

The migrations appear to be out of sync.

git diff origin/stable..origin/ubuntu-20.04-upgrade --stat --no-renames data

 data/migrations/deb/1_0_28_to_1_0_29.py          |  29 ---
 data/migrations/deb/1_0_96_to_1_0_97.py          |  29 +++
 data/migrations/deb/1_1_37_to_1_1_38.py          |  29 ---
 data/migrations/deb/1_1_43_to_1_2_44.py          |  41 -----
 data/migrations/deb/1_1_150_to_1_1_151.py        |  41 +++++
 data/migrations/deb/1_2_44_to_1_2_45.py          | 198 --------------------
 data/migrations/deb/1_2_50_to_1_2_51.py          |  96 ----------
 data/migrations/deb/1_2_51_to_1_2_52.py          |  19 --
 data/migrations/deb/1_2_188_to_1_2_189.py        | 198 ++++++++++++++++++++
 data/migrations/deb/1_2_233_to_1_2_234.py        |  96 ++++++++++
 data/migrations/deb/1_2_273_to_1_2_274.py        |  19 ++
 data/migrations/deb/disabled_1_0_29_to_1_0_28.py | 216 ----------------------
 data/migrations/deb/disabled_1_0_97_to_1_0_96.py | 216 ++++++++++++++++++++++
 data/migrations/deb/helper_1_0_28_to_1_0_29.py   | 223 -----------------------
 data/migrations/deb/helper_1_0_96_to_1_0_97.py   | 223 +++++++++++++++++++++++
 data/migrations/deb/helper_1_1_37_to_1_1_38.py   | 191 -------------------

• [ ] environment/docker/baseimage/indy-baseimage.ubuntu.dockerfile

This file seems to be specific to Ubuntu 16.

• [ ] environment/docker/pool/core.ubuntu.dockerfile

This file seems to be specific to Ubuntu 16.

• [ ] environment/openshift/core.ubuntu.dockerfile

This file seems to be specific to Ubuntu 16.

• [ ] indy_common/test/auth/metadata/test_auth_rule_with_metadata_complex.py
• [ ] indy_common/test/auth/metadata/test_auth_rule_with_metadata_composite.py
• [ ] indy_common/test/auth/metadata/test_auth_rule_with_metadata_simple.py
• [ ] indy_common/test/test_util.py
• [ ] indy_node/server/request_handlers/domain_req_handlers/nym_handler.py
• [ ] indy_node/test/auth_rule/test_auth_rule_transaction.py
• [ ] indy_node/test/conftest.py
• [ ] indy_node/test/node_control_utils/test_node_control_util.py
• [ ] indy_node/test/pool_restart/test_pool_restart.py
• [ ] indy_node/test/request_handlers/test_nym_handler.py
• [ ] runner.py
• [ ] scripts/performance/perf_load/perf_processes.py
• [ ] scripts/performance/perf_load/perf_utils.py
• [ ] scripts/restart_indy_node_ubuntu1604.sh

This file is specific to Ubuntu 16.04. Do we need to upgrade the script?

[swcurran]

FYI @WadeBarnes @pSchlarb --- can we get from this a specific list of actions to be taken to the Ubuntu 20.04 branches in Indy Node and Plenum before retiring the old main and stable branches?

[pSchlarb]

Hm one thing that comes to my mind is the documentation changes in main(espiacially the new network doc) that aren't in the ubuntu20 branch. But main wasn't compared here.

Regarding the old dockerfiles(core.ubuntu.dockerfile, indy-baseimage.ubuntu.dockerfile) it is save to say, that they aren't needed anymore in ubuntu20. They have been superseeded with the devcontainers in my thesis work.

I feel not confident making a decision regarding the other code changes, since i have been mainly working on the pipelines and devcontainers.