search

hyperledger / indy-node

The server portion of a distributed ledger purpose-built for decentralized identity.
https://wiki.hyperledger.org/display/indy
Apache License 2.0
685 stars 657 forks source link

Update requests.md #1815

Closed ayush4345 closed 1 year ago

ayush4345 commented 1 year ago

fixed broken link problem in the Requests page of the Documentation

fixed issue #1683

ayush4345 commented 1 year ago

image

how to fix this issue as expected sign and what it got is same then why it is failed

swcurran commented 1 year ago

All commits must be signed off by DCO - Developer Certificate of Origin - https://github.com/apps/dco. To do that on the command line, you must use the “-s” option on your commit (e.g., git commit -s -m “Comment about my commit”). If you created these changes in the GitHub UI, you should have seen this dialog. In that you must select your email address that GitHub knows you by:

image

It looks like that is what you did. Did you edit the text in the signoff in any way? If so, that would invalidate the signoff:

fixed boken link problem in Requests page of Documentation 

Signed-off-by: Ayush  <99096397+ayush4345@users.noreply.github.com>

If not — I’m not sure what the issue is.

ayush4345 commented 1 year ago

@swcurran i have used Github UI and commited the code.i don't know why i am getting DCO error. So, I have created a new pull request new pull request. This passed the DCO test. This time i have used terminal to signoff the commit. Please look into that

swcurran commented 1 year ago

Awesome — much appreciated. I’d love to know why the signoff failed the first time — it’s a weird one...

ayush4345 commented 1 year ago

Awesome — much appreciated. I’d love to know why the signoff failed the first time — it’s a weird one...

actually even I don't know why signoff failed.it seems when ever we use github UI to commit our changes and signoff the commit.This error occurs, this happened with me earlier also.Also error message is also not clear as it getting what it is expecting still there is error

Apparently signoff using terminal fixes this issue

ayush4345 commented 1 year ago

@swcurran can u have a look at new pull request