search

hyperledger / indy-plenum

Plenum Byzantine Fault Tolerant Protocol
https://wiki.hyperledger.org/display/indy
Apache License 2.0
215 stars 370 forks source link

Align local and GHA build processes #1556

Closed WadeBarnes closed 2 years ago

WadeBarnes commented 3 years ago

The Ubuntu 16.04 and 20.04 builds follow a similar pattern, the 16.04 pattern is being used as the example since the 20.04 files are currently in a pending PR.

The GHA workflows introduced a new Dockerfiles to create the build/test images. The Jenkins/local build processes also have a Dockerfile to create the image used for builds. The associated build-*-docker.sh scripts are not used by the GHA workflows, but the other build scripts are used by both processes.

Having a way to build the project locally in docker is handy, however there should only be one Dockerfile defining the build image.

Consolidate the docker files for the two build processes so there is only a single one shared by the two processes.

These updates should be developed on the branch containing the updates for Ubuntu 20.04. Currently ubuntu-20.04-upgrade, and done after this PR is merged; https://github.com/hyperledger/indy-plenum/pull/1545

WadeBarnes commented 2 years ago

Addressed with https://github.com/hyperledger/indy-plenum/pull/1583