Rework Buildimage and Pipeline due to Circular Dependency of Rocksdb in Build Image

pSchlarb commented 1 year ago

While trying to fix #1632 with #1633 @WadeBarnes and I found out, that the rocksdb is also installed in the buildimage for node and plenum and is only published to the artifactory by the "3rd party dependencies" of the plenum build, which is using the same buildimage. The problem is, that the 3rd-party dependencies publish to the artifactory in its current form doesn't override a version (which we were trying to do so to fix #1632). Deleting the rocksdb package to be able to push an update resulted in the pipeline failing, since it was needed it in the buildimage creation.

The idea is to:

[x] move to a slimmed down buildimage(only the dependencies needed for creating the package),
[x] rearrange the pipeline so that it installs node with the just built package for testing, which should pull in all the required dependencies.
[x] rework the indy-shared-gha call of the jfrog-cli to be able to override/update files (maybe just permissions for the token )

pSchlarb commented 1 year ago

Permissions to overwrite existing packages have been set by @WadeBarnes. Will be tested with the rest.

WadeBarnes commented 1 year ago

Rerunning https://github.com/hyperledger/indy-plenum/actions/runs/4265960540 to test whether the RocksDB package gets updated as expected now.

Update: The packages were successfully updated.

hyperledger / indy-plenum

Rework Buildimage and Pipeline due to Circular Dependency of Rocksdb in Build Image #1634