search

hyperledger / indy-test-automation

Automation tools for testing of Indy Project components.
https://wiki.hyperledger.org/display/indy
Apache License 2.0
6 stars 23 forks source link

Correct dockerfiles to run the tests successfully again. split prepa… #103

Closed devinleighsmith closed 3 years ago

devinleighsmith commented 3 years ago

…re script to allow better caching.

Signed-off-by: Devin Smith devinleighsmith@gmail.com

devinleighsmith commented 3 years ago

Based off of https://github.com/hyperledger/indy-test-automation/pull/101

Primary motivations: 1) fix issues preventing existing tests from running. 2) split prepare script up to allow created dockerfiles to be individually cached. 3) update sovrin dependency to allow it to be installed via the GHA within the sovrin repo (by default sovrin is not required in these tests).

WadeBarnes commented 3 years ago

@askolesov, @Toktar, Could you please review and merge?

Toktar commented 3 years ago

Could you please fix DCO sign for commit 9f1d91f and resolve conflicts. Changes look excellent. I'll approve them after fixes.

devinleighsmith commented 3 years ago

@Toktar @askolesov I had to make a few updates to get 100% of the tests to pass, viewable here: https://github.com/devinleighsmith/sovrin/runs/2468937322?check_suite_focus=true

should be good for approval now.

WadeBarnes commented 3 years ago

@Toktar @askolesov, are you able to provide a final review, then approve and merge?