search

hyperledger / indy-test-automation

Automation tools for testing of Indy Project components.
https://wiki.hyperledger.org/display/indy
Apache License 2.0
6 stars 23 forks source link

Sovrin Call enabled #120

Closed pSchlarb closed 1 year ago

pSchlarb commented 1 year ago

Fixes --payments flag. Addition of Sovrin callable GithubActions workflow. Removal of duplicates. Forced LF endings

pSchlarb commented 1 year ago

I don't think they should be deleted, because they provide a handy way to create the images, when working locally and not in GHA.

WadeBarnes commented 1 year ago

I don't think they should be deleted, because they provide a handy way to create the images, when working locally and not in GHA.

The prepare.sh script is used for that. It builds the client and node images. prepare_client.sh and prepare_node.sh, in their current state do not match how the images are being built in the prepare.sh script. If they are to be kept, they will need to be updated, which is extra development and testing effort to keep them synced with the processes in the prepare.sh script. I'm recommending removing them for that reason.