search

hyperledger / indy-vdr

A library and proxy server for interacting with Hyperledger Indy Node ledger instances
Apache License 2.0
55 stars 71 forks source link

Fix check for macos major version #291

Closed andrewwhitehead closed 6 months ago

swcurran commented 6 months ago

I gather this didn’t fix the issue?

cvarjao commented 6 months ago

Switching to macos-12 get us back to a working pipeline. Maybe in a separate PR, we should still review compatibility with macos 14.

Changes: https://github.com/hyperledger/indy-vdr/compare/main...cvarjao-o:indy-vdr:fix-cd?expand=1

Execution: https://github.com/cvarjao-o/indy-vdr/actions/runs/9259858312

XCode MacOS 12 Runner: https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md MacOS 14 Runner: https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md

andrewwhitehead commented 6 months ago

Pinning cc to 1.0.83 seems to help the Darwin build on 14.x. I'm not sure if the exact issue has been reported but there are some potentially related cross compilation issues.

There's still an error in the iOS build occurring with cc pinned. In particular, this command seems to mix different architectures:

/usr/bin/clang -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -arch arm64 -MD -MT CMakeFiles/cmTC_e5ae3.dir/testCCompiler.c.o -MF CMakeFiles/cmTC_e5ae3.dir/testCCompiler.c.o.d -o CMakeFiles/cmTC_e5ae3.dir/testCCompiler.c.o -c /Users/runner/work/indy-vdr/indy-vdr/target/x86_64-apple-ios/release/build/zmq-sys-cb80815203982fd7/out/build/CMakeFiles/CMakeScratch/TryCompile-YFxGth/testCCompiler.c

I'm going to limit this PR to just fixing the minor version detection issue in build-universal.sh.

andrewwhitehead commented 6 months ago

@cvarjao Could you create a PR for your changes

cvarjao commented 6 months ago

Sure thing, here it is: