search

hyperledger / indy-vdr

A library and proxy server for interacting with Hyperledger Indy Node ledger instances
Apache License 2.0
55 stars 71 forks source link

feat: added improved gh actions #293

Closed wadeking98 closed 5 months ago

wadeking98 commented 5 months ago

Added github actions to automatically publish alpha versions to npm. Included binaries in react native package so we have a smoother release cycle without having to wait for a binary release

This PR does not effect the usual release cycle, this only adds alpha releases. Normal major releases will still have to be triggered manually

cvarjao commented 5 months ago

@andrewwhitehead , @berendsliedrecht , can we get this merged for us to be able to get alpha release for the react native wrapper?

TimoGlastra commented 5 months ago

Included binaries in react native package so we have a smoother release cycle without having to wait for a binary release

It is generally not advised to push such big binaries to the NPM registry. Also because it means you download the binaries for all platforms when you install the package rather than just the binary for your platform.

So from my side this would be a No to merging this PR as is. Maybe we can look at creating pre-releases on github, so that we download the binary and not have to include it in the package.