search

hyperledger / indy-vdr

A library and proxy server for interacting with Hyperledger Indy Node ledger instances
Apache License 2.0
54 stars 71 forks source link

chore: maintenance update js wrapper #296

Open TimoGlastra opened 4 months ago

TimoGlastra commented 4 months ago

Updates the JS wrapper:

wadeking98 commented 4 months ago

Also if it's not too much trouble do you mind incorporating the changes in from this PR? https://github.com/hyperledger/indy-vdr/pull/270

Just the changes from these files:

otherwise I can do it in a separate PR if you'd prefer

TimoGlastra commented 4 months ago

Also if it's not too much trouble do you mind incorporating the changes in from this PR? https://github.com/hyperledger/indy-vdr/pull/270

Just the changes from these files:

  • wrappers/javascript/indy-vdr-nodejs/src/library/bindings.ts

  • wrappers/javascript/indy-vdr-nodejs/tests/IndyVdrTxnCache.test.ts

  • wrappers/javascript/indy-vdr-react-native/cpp/indyVdr.cpp

  • wrappers/javascript/indy-vdr-react-native/cpp/turboModuleUtility.cpp

otherwise I can do it in a separate PR if you'd prefer

Yes, will do!

TimoGlastra commented 4 months ago

@berendsliedrecht @andrewwhitehead any idea why the macOS build is suddenly failing? Only made changes to the JS wrapper

wadeking98 commented 4 months ago

@TimoGlastra not sure why it's just failing for the mac build, try updating time to 0.3.36 in the Cargo.toml file in libindy_vdr

TimoGlastra commented 4 months ago

Still failing sadly @berendsliedrecht

TimoGlastra commented 4 months ago

Now sure what is happening with the segmentation vault now ... :/

berendsliedrecht commented 4 months ago

@TimoGlastra could it be related to vitest?

TimoGlastra commented 4 months ago

Yeah maybe 🤷 Haven't found the time to look into it yet :(