Loosen time dependency patch version constraint

hyperledger / indy-vdr

A library and proxy server for interacting with Hyperledger Indy Node ledger instances

Apache License 2.0

55 stars 71 forks source link

Loosen time dependency patch version constraint #332

Closed gmulhearn-anonyome closed 1 month ago

gmulhearn-anonyome commented 2 months ago

Previously we were locked into time =0.3.20: https://github.com/hyperledger/indy-vdr/pull/166

Recently it was updated to =0.3.36 due to issues with rust 1.80 and <0.3.36 versions of time.

However just as a crate cleanliness, it would be nice to only pin the version to 0.3.36 if we absolutely have to, dep conflicts may arise for consumers of the indy-vdr in the future as a result etc

FYI @andrewwhitehead : RE your original decision to lock the time version, is it still necessary?

andrewwhitehead commented 1 month ago

There hasn't been a new release of the time crate past 0.3.36 so this doesn't have any effect right now. It's possible that a new release would increase the minimum Rust version past what we currently need for the Android build, but that's true of the other dependencies as well so I don't think it hurts to loosen this up for now.