hyperledger / indy-vdr

A library and proxy server for interacting with Hyperledger Indy Node ledger instances
Apache License 2.0
54 stars 71 forks source link

StateProof verification fails silently #81

Open domwoe opened 2 years ago

domwoe commented 2 years ago

We noticed, that Indy VDR performs a state proof verification for each response of a read request to the ledger, but it seems there's no indication if the verification was successful or failed (except a trace message).

Did I miss anything here?

andrewwhitehead commented 2 years ago

This is by design, and consistent with the behaviour in indy-sdk. IIRC the state proof verification may fail when generated for a different epoch (which changes every 5 minutes) due to clock skew or delays in receiving the response from the server. I don't think every response type supports a state proof either. But a consensus response from the verifier nodes is also considered acceptable, this is generally n / 3 + 1 identical responses where n is the number of verifier nodes.