search

hyperledger / solang

Solidity Compiler for Solana and Polkadot
https://solang.readthedocs.io/
Apache License 2.0
1.25k stars 208 forks source link

Add Polkadot Node CLI Interactions #1515

Closed tareknaser closed 1 year ago

tareknaser commented 1 year ago
xermicus commented 1 year ago

The entire PR is mostly a blatant copy of the code in cargo contract. Without even crediting the source. Which is unacceptable and might even be subject to license violations.

xermicus commented 1 year ago

In the review I Just misclicked, I do NOT approve these changes.

Please, if you'd like to re-use code from another codebase, factoring it out into a library, which then can be re-used properly, would be the way to go.

tareknaser commented 1 year ago

Could you elaborate more on how to do the PR? My intention was to replicate cargo-contract's functionality to meet solang’s needs.

To clarify, are there specific functions or aspects of cargo-contract code that we should implement differently in solang? I'd like to ensure we align with solang’s goals while respecting licensing.

I'll redo the PR from scratch and appreciate your guidance.

xermicus commented 1 year ago

Could you elaborate more on how to do the PR?

You copied vast amount of code from cargo contract, without crediting the source, and without respecting the license. Which constitutes an unacceptable contribution. This is why I closed the PR.

My intention was to replicate cargo-contract's functionality to meet solang’s needs. To clarify, are there specific functions or aspects of cargo-contract code that we should implement differently in solang? I'd like to ensure we align with solang’s goals while respecting licensing.

Copy + Pasting code is almost never the right approach. If you feel like cargo contract already has got everything you'd need, you should think about how you can turn the parts you need from cargo contract into a re-usable crate instead. Just like it was done with extrinsics.