search

hyperledger / solang

Solidity Compiler for Solana and Polkadot
https://solang.readthedocs.io/
Apache License 2.0
1.22k stars 207 forks source link

Fix panics caused by shifting(#1618) #1627

Closed yp945 closed 4 months ago

yp945 commented 4 months ago

Fixed the bug where there was no load when the right expression of the shift calculation is a structure member.

yp945 commented 4 months ago

This could really use a test case

Ok, I will add a test case.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.58%. Comparing base (0bea68c) to head (f33fbaa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1627 +/- ## ========================================== - Coverage 88.58% 88.58% -0.01% ========================================== Files 150 150 Lines 69331 69342 +11 ========================================== + Hits 61416 61424 +8 - Misses 7915 7918 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yp945 commented 4 months ago

I have successfully run the cargo test --workspace command locally, but it failed on CI. I'm not sure if it's due to recent changes.

seanyoung commented 4 months ago

I have successfully run the cargo test --workspace command locally, but it failed on CI. I'm not sure if it's due to recent changes.

It was an intermittent failure in the integration tests. Rerunning it fixed the problem.