search

hyperledger / toc

Hyperledger TOC documents
https://toc.hyperledger.org/
Creative Commons Attribution 4.0 International
35 stars 44 forks source link

Refactor folder structure #11

Closed arsulegai closed 2 years ago

arsulegai commented 3 years ago

Here is a screenshot from locally rendered site

image

arsulegai commented 3 years ago

I'm not against it but given the small number of files we are currently dealing with I have to ask whether this is really worth it.

I'm ok to close or keep a private fork of PR branch if this is not helpful. Either sounds fine to me.

  1. Folder structure refactoring will allow one to group together a category of governance documents into one folder.
  2. A developer debug option will allow one to render the page locally, verify any bugs priori.
lehors commented 3 years ago

I'm not against it but given the small number of files we are currently dealing with I have to ask whether this is really worth it.

I'm ok to close or keep a private fork of PR branch if this is not helpful. Either sounds fine to me.

1. Folder structure refactoring will allow one to group together a category of governance documents into one folder.

2. A developer debug option will allow one to render the page locally, verify any bugs priori.

I suggest you move the debug option to a different PR anyway. As for the folder refactoring I understand the rationale. I just think we have so few files anyway that this won't make much difference. But, again, I'm not against it so I'm happy to leave it to others to decide whether they think this is worth it.

arsulegai commented 3 years ago

I'm not against it but given the small number of files we are currently dealing with I have to ask whether this is really worth it.

I'm ok to close or keep a private fork of PR branch if this is not helpful. Either sounds fine to me.

1. Folder structure refactoring will allow one to group together a category of governance documents into one folder.

2. A developer debug option will allow one to render the page locally, verify any bugs priori.

I suggest you move the debug option to a different PR anyway. As for the folder refactoring I understand the rationale. I just think we have so few files anyway that this won't make much difference. But, again, I'm not against it so I'm happy to leave it to others to decide whether they think this is worth it.

Moved as per suggestion https://github.com/hyperledger/tsc/pull/12