Closed ben9809 closed 1 week ago
Also getting conflicts with other Eth based development applications.
I think eth-utils
, eth-account
, and msgpack
should be updated too because the newest versions fix so many bugs and memory leakages
Sorry it took me so long to review this, but I don't think this works on python 3.7
poetry build
My poetry installation is setup to use python 3.10
I then copied this wheel to another directory and activate a python 3.7 virtual environment. I then attempted to install the wheel file: python -m pip install hyperliquid_python_sdk-0.5.0-py3-none-any.whl
Processing ./hyperliquid_python_sdk-0.5.0-py3-none-any.whl
Collecting eth-abi<4.0.0,>=3.0.1; python_version >= "3.7" and python_version < "3.8"
Using cached eth_abi-3.0.1-py3-none-any.whl (28 kB)
Collecting msgpack<2.0.0,>=1.0.5
Downloading msgpack-1.0.5.tar.gz (127 kB)
|████████████████████████████████| 127 kB 3.6 MB/s
Installing build dependencies ... done
Getting requirements to build wheel ... done
Installing backend dependencies ... done
Preparing wheel metadata ... error
ERROR: Command errored out with exit status 1:
command: /Users/ben/.pyenv/versions/3.7/bin/python3 /Users/ben/.pyenv/versions/3.7/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py prepare_metadata_for_build_wheel /var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/tmp3z0d3zs3
cwd: /private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-install-gosxsvzg/msgpack
Complete output (61 lines):
running dist_info
creating /private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-modern-metadata-ngfcgwvu/msgpack.egg-info
writing /private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-modern-metadata-ngfcgwvu/msgpack.egg-info/PKG-INFO
writing dependency_links to /private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-modern-metadata-ngfcgwvu/msgpack.egg-info/dependency_links.txt
writing top-level names to /private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-modern-metadata-ngfcgwvu/msgpack.egg-info/top_level.txt writing manifest file '/private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-modern-metadata-ngfcgwvu/msgpack.egg-info/SOURCES.txt'
reading manifest file '/private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-modern-metadata-ngfcgwvu/msgpack.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.c' under directory 'msgpack'
adding license file 'COPYING'
writing manifest file '/private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-modern-metadata-ngfcgwvu/msgpack.egg-info/SOURCES.txt'
creating '/private/var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/pip-modern-metadata-ngfcgwvu/msgpack-1.0.5.dist-info'
Traceback (most recent call last):
File "/Users/ben/.pyenv/versions/3.7/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py", line 280, in ERROR: Command errored out with exit status 1: /Users/ben/.pyenv/versions/3.7/bin/python3 /Users/ben/.pyenv/versions/3.7/lib/python3.7/site-packages/pip/_vendor/pep517/_in_process.py prepare_metadata_for_build_wheel /var/folders/yy/p2gk9yz56fq646yjws6bgh3w0000gn/T/tmp3z0d3zs3 Check the logs for full command output.
I don't see why this change would cause this error, but I don't have an issue with following the same steps to install the wheel without this change
Python 3.7 is end of life and we have very little 3.7 usage: https://pypistats.org/packages/hyperliquid-python-sdk Hopefully I'll have time to drop 3.7 support and then it should be easier to upgrade these dependencies
@traderben I think it would be a good idea to drop the 3.7 version.
Let me know when you plan to do it, I could help upgrade the other dependencies in case!
I published a new version that drops support for 3.7
https://github.com/hyperliquid-dex/hyperliquid-python-sdk/pull/60 upgraded the eth-abi dependency, so I'm going to close this PR. Feel free to open a new one if there's a compelling reason to upgrade further
This pull request updates the
eth-abi
dependency in thehyperliquid-python-sdk
project. The changes are as follows:eth-abi
version inpyproject.toml
to support both Python 3.7 and Python 3.8+.eth-abi
update.This update ensures that hyperliquid SDK stays up-to-date with the latest
eth-abi
version, improving its compatibility and performance with Ethereum-based operations.Please review the changes and let me know if there are any concerns or suggestions.