If WsManager is dropped, the spawned tokio tasks aren't stopped

hyperliquid-dex / hyperliquid-rust-sdk

MIT License

68 stars 49 forks source link

If WsManager is dropped, the spawned tokio tasks aren't stopped #47

Closed Frixoe closed 2 months ago

Frixoe commented 3 months ago

This is an issue because if WsManager is stopped, the two tokio tasks are still running in the background which could cause performance issues and certainly populates logs.

abrkn commented 3 months ago

i'm facing this issue as well

Frixoe commented 3 months ago

Yeah, I've created a fix, waiting for my previous PR to be merged so I can open a PR for that.