hyperliquid-dex / hyperliquid-rust-sdk

MIT License
57 stars 47 forks source link

Fix #47: Handle WsManager Drop and close the ping and reader tasks #51

Closed Frixoe closed 1 month ago

Frixoe commented 1 month ago

Fixing #47 to make sure no tasks are orphaned once the WsManager is dropped.

lmlmt commented 1 month ago

Also missed this minor nit from earlier: https://github.com/hyperliquid-dex/hyperliquid-rust-sdk/pull/46/files#r1727383937 Figured it would be easy to just get it into this PR as well

Frixoe commented 1 month ago

Also missed this minor nit from earlier: https://github.com/hyperliquid-dex/hyperliquid-rust-sdk/pull/46/files#r1727383937 Figured it would be easy to just get it into this PR as well

Nw, I'll make the change. I think the CI step is stuck lol. Anything you can do here or will it time out?

Frixoe commented 1 month ago

Just went through the code and I've already made the change so we're good

lmlmt commented 4 days ago

@Frixoe this is causing this issue (https://github.com/hyperliquid-dex/hyperliquid-rust-sdk/issues/59) to surface. Can reproduce it on my end. Reverting this for now - feel free to fix in a separate PR

Frixoe commented 4 days ago

@lmlmt Will fix