hyperlog-core / hyperlog-backend

Backend for hyperlog
0 stars 0 forks source link

Allow signup and login with GitHub #101

Closed nikochiko closed 4 years ago

nikochiko commented 4 years ago

Fixes #102

Changes:

BrainBuzzer commented 4 years ago

If the user doesn't change the username, aka submits the same username that is currently assigned, the user mutation changeUsername should return true and set newUser to false.

nikochiko commented 4 years ago

Is that different from the current functionality?

BrainBuzzer commented 4 years ago

It works sometimes, but sometimes it doesn't. I was getting an error that the username is already in use. And then everything was working 3-4 tries later.

BrainBuzzer commented 4 years ago

No need to fix it just yet though because I haven't encountered that same error since then.

nikochiko commented 4 years ago

It works sometimes, but sometimes it doesn't. I was getting an error that the username is already in use. And then everything was working 3-4 tries later.

That's strange. I'll test it out a bit more